Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent potential modal window close segfault #22540

Merged
merged 1 commit into from
Mar 5, 2020
Merged

fix: prevent potential modal window close segfault #22540

merged 1 commit into from
Mar 5, 2020

Conversation

codebytere
Copy link
Member

Backport of #22410

See that PR for details.

Notes: Fixed an occasional segfault with modal windows being closed or destroyed.

@codebytere codebytere requested a review from a team March 5, 2020 03:41
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 5, 2020
@trop trop bot mentioned this pull request Mar 5, 2020
Merged
5 tasks
@trop trop bot added 7-1-x backport This is a backport PR labels Mar 5, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 5, 2020
@codebytere codebytere merged commit a632f1f into 7-1-x Mar 5, 2020
@release-clerk
Copy link

release-clerk bot commented Mar 5, 2020

Release Notes Persisted

Fixed an occasional segfault with modal windows being closed or destroyed.

@codebytere codebytere deleted the fix-modal-death-7 branch March 5, 2020 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
7-1-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @zcbenz